Module: Fix enrichment of type info via Module imports
#448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Type info gets attached via updated imports, and we would only consider local imports. By including parent imports, we now get type infor attached, even if the import lives in the parent module.
|
Documentation for this branch can be viewed at https://sites.ecmwf.int/docs/loki/448/index.html |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #448 +/- ##
=======================================
Coverage 93.19% 93.20%
=======================================
Files 219 219
Lines 40908 40929 +21
=======================================
+ Hits 38126 38147 +21
Misses 2782 2782
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
reuterbal
added
the
ready for merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses issue #428 . Many thanks to @wertysas for the excellent reproducer and test
The problem was essentially that we would drop type info for subroutines if the info enrichment came though type imports on the parent
Module. This is easily fixed by including parent imports in the enrichment loop over Imports.I took the opportunity to also clean up the import on
test_module.pyin the process.